Skip to content

remove unnecessary $convert in ObjectIdAutoField $lookup queries #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 28, 2024
Merged

remove unnecessary $convert in ObjectIdAutoField $lookup queries #176

merged 2 commits into from
Oct 28, 2024
+45 −0

Conversation

WaVEV
Copy link
Collaborator

@WaVEV WaVEV commented Oct 26, 2024

No description provided.

@WaVEV WaVEV requested a review from timgraham October 26, 2024 20:10
@timgraham timgraham force-pushed the fix-join-incorrect-cast-on-foreign-keys branch from 529bcfb to 221a282 Compare October 28, 2024 12:33
@timgraham timgraham changed the title Define ObjectIdAutoField rel_db_type. remove unnecessary $convert in ObjectIdAutoField $lookup queries Oct 28, 2024
timgraham
timgraham approved these changes Oct 28, 2024
View reviewed changes
Copy link
Collaborator

@timgraham timgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a regression test, okay?

@WaVEV
Copy link
Collaborator Author

WaVEV commented Oct 28, 2024

I added a regression test, okay?

Yes, it is.

@timgraham timgraham merged commit 221a282 into mongodb:main Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timgraham timgraham timgraham approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@WaVEV @timgraham